fosster/rexcrypt
1
0
Fork 0
Code Issues Pull requests Projects Releases 3 Packages Wiki Activity Actions

WIP: refactor(core): refactor select_alg to no longer require heap allocation & strncpy() #7

Manually merged
sezieru merged 2 commits from refactor/alt-select into feature/verify-alg 2025-10-15 09:14:48 +00:00
Conversation 1 Commits 2 Files changed 1 +17 -40
sezieru commented 2025-10-15 08:46:23 +00:00
Owner
Copy link

Refactors select_alg():

  • No longer requires an extra variable pfx.
  • Eliminates need for heap allocation.
  • Eliminates need for strncpy().
  • Eliminates need to call free(), in either select_alg() or in main() (for tok).
  • Simplifies function operation.
  • Allows compiler to optimize as jmp table.
  • Updates associated comments.
Refactors `select_alg()`: - [x] No longer requires an extra variable `pfx`. - [x] Eliminates need for heap allocation. - [x] Eliminates need for `strncpy()`. - [x] Eliminates need to call `free()`, in either `select_alg()` or in `main()` (for `tok`). - [x] Simplifies function operation. - [x] Allows compiler to optimize as jmp table. - [ ] Updates associated comments.
sezieru self-assigned this 2025-10-15 08:46:23 +00:00
sezieru commented 2025-10-15 08:49:56 +00:00
Author
Owner
Copy link

Refactors select_alg():

  • No longer requires an extra variable pfx.
  • Eliminates need for heap allocation.
  • Eliminates need for strncpy().
  • Eliminates need to call free(), in either select_alg() or in main() (for tok).
  • Simplifies function operation.
  • Allows compiler to optimize as jmp table.
  • Updates associated comments.

Pull-ready.

Refactors `select_alg()`: - [x] No longer requires an extra variable `pfx`. - [x] Eliminates need for heap allocation. - [x] Eliminates need for `strncpy()`. - [x] Eliminates need to call `free()`, in either `select_alg()` or in `main()` (for `tok`). - [x] Simplifies function operation. - [x] Allows compiler to optimize as jmp table. - [x] Updates associated comments. **Pull-ready.**
requested review from Owners 2025-10-15 08:54:38 +00:00
sezieru manually merged commit f51000a084 into feature/verify-alg 2025-10-15 09:14:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fosster/Owners
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
sezieru
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: fosster/rexcrypt#7
No description provided.
Delete branch "refactor/alt-select"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?